Add support for publishing native-engine to s3. #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should close out #4800 |
benjyw
approved these changes
Aug 9, 2017
| @@ -51,6 +51,7 @@ GRTAGS | |||
| GSYMS | |||
| GTAGS | |||
|
|
|||
| # Generated by build-support/bin/generate-bintray-manifest.sh for | |||
| # Generated by build-support/bin/prepare-binary-deploy.sh for | |||
| # use by Travis-CI bintray deploys. | |||
There was a problem hiding this comment.
s/bintray deploys/bintray and S3 deploys/ ?
There was a problem hiding this comment.
I'll leave as is and merge the green CI. Should be fixed though - agreed.
| - provider: s3 | ||
| access_key_id: AKIAIQHTQI5E42SQBSNA | ||
| secret_access_key: | ||
| secure: RQVzsNfZL8AgsXdjZ67j2tWs5Tjl/FKpmE1fyVgldMbua/xhW8dzdFrtOeWjTPX4/+sJZ4U7/tZectBtWejmrXUJiZQKJwJBnsyYxysENTWOV80BEYyoz2RPr8HSVbMZ1ZHtUafzO3OqV1x+Pvgpg8FUeUfsy3TGUk0JREO90Q0= |
There was a problem hiding this comment.
Out of curiosity, how is "security" provided here? Is this a key into a travis data store that can only be accessed from our running instances?
There was a problem hiding this comment.
Its this: http://docs.travis-ci.com/user/encryption-keys/
We have 3 defined at the top of .travis.yml as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.