Move .pids under .pants.d by default #19911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3511 |
|
In general, I'm for this change 👍 |
kaos
approved these changes
Sep 22, 2023
kaos
approved these changes
Sep 22, 2023
|
@stuhood why is |
AlexTereshenkov
pushed a commit
that referenced
this pull request
Feb 14, 2024
Update the `pants.log` file location after the changes in #19911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also make the workdir a subdir of
.pants.d, so that it's easy tonuke it without nuking the pids. These are just changes to default
option values. It is still possible to explicitly set those options so
whatever the user wants.
The structure under
.pants.dis opaque to end users and not partof the API, so we have the freedom to do this without a deprecation.
Note that we do not move
.pants.d/bspunder.pants.d/workdir.For whatever reason,
bspuses that hardcoded directory, ratherthan consulting the pants_workdir option.
So the end result of this change is that
.pants.dis no longer thesame thing as the workdir, but a looser "directory Pants writes stuff
under, and that you can safely nuke". There are now three things that
go under that dir: pids, workdir and bsp.