You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passes git diff upstream/master --name-only -- '*.py' | flake8 --diff (but not clear to me if I did properly, because the first of the pipe only reports the filename of the changed file, no actual diff.)
My first objective was to clarify the role of column vs value keyword.
For the reference, this is how this function is documented on http://stackoverflow.com/a/18674915/2822346. Function call is presented as df.insert(idx, col_name, value). I find the col_name slightly more explicit than just column, which is ambiguous (i.e. "does column holds the Series?"). But of course this name cannot change without breaking the API. So this small PR is just an attempt to clarify things.
Since I was touching the docstring, I've also make it a bit more tidy (e.g. removed a too long line).
jorisvandenbossche
changed the title
minor enhancement of DataFrame.insert docstring
DOC: minor enhancement of DataFrame.insert docstring
May 12, 2017
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jorisvandenbossche
changed the title
pierre-haessig
force-pushed
the
insert-docstring
branch
from
git diff upstream/master --name-only -- '*.py' | flake8 --diff(but not clear to me if I did properly, because the first of the pipe only reports the filename of the changed file, no actual diff.)My first objective was to clarify the role of
columnvsvaluekeyword.For the reference, this is how this function is documented on http://stackoverflow.com/a/18674915/2822346. Function call is presented as
df.insert(idx, col_name, value). I find thecol_nameslightly more explicit than justcolumn, which is ambiguous (i.e. "does column holds the Series?"). But of course this name cannot change without breaking the API. So this small PR is just an attempt to clarify things.Since I was touching the docstring, I've also make it a bit more tidy (e.g. removed a too long line).