Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate flask.ext #1484

Merged
merged 4 commits into from
Apr 2, 2016
Merged

Deprecate flask.ext #1484

merged 4 commits into from
Apr 2, 2016

Conversation

untitaker
Copy link
Contributor

See #1135

@untitaker
Copy link
Contributor Author

cc @DasIch (now on the PR properly)

@untitaker untitaker mentioned this pull request Jun 6, 2015
Closed
@untitaker untitaker added this to the 1.0 milestone Jun 14, 2015
@ThiefMaster
Copy link
Member

Would it make sense to show a different warning in case a flask.ext import points to an old flaskext package?

@untitaker
Copy link
Contributor Author

@ThiefMaster fixed, an additional warning is now shown. One is addressing the app dev, the other the extension dev.

@prologic prologic mentioned this pull request Aug 11, 2015
Open
@davidism
Copy link
Member

What are we waiting on to merge this?

@untitaker
Copy link
Contributor Author

Feel free to do so.

On 31 October 2015 05:02:17 CET, David Lord notifications@github.com wrote:

What are we waiting on to merge this?

Reply to this email directly or view it on GitHub:
#1484 (comment)

Sent from my phone. Please excuse my brevity.

@jeffwidman
Copy link
Contributor

Can someone rebase and then merge this?

Seems like this is all that's needed to check one of the #1182 checkboxes.

@untitaker untitaker force-pushed the ext-deprecation-new branch from 7f30cdb to 7ede661 Compare April 2, 2016 19:01
@untitaker untitaker assigned untitaker and mitsuhiko and unassigned untitaker Apr 2, 2016
@mitsuhiko
Copy link
Contributor

Let's merge this.

@untitaker untitaker merged commit d3d8a46 into pallets:master Apr 2, 2016
@untitaker untitaker deleted the ext-deprecation-new branch April 2, 2016 19:06
untitaker added a commit that referenced this pull request Apr 2, 2016
@untitaker
Changelog for #1484
7f26d45
@jeffwidman jeffwidman mentioned this pull request Apr 4, 2016
Closed
@methane methane mentioned this pull request Apr 4, 2016
Closed
6 tasks
This was referenced Apr 5, 2016
Merged
Closed
@kevinvalk kevinvalk mentioned this pull request Jun 29, 2016
Closed
@joeyespo joeyespo mentioned this pull request Jul 11, 2016
Closed
@fourbytes fourbytes mentioned this pull request Jul 24, 2016
Merged
mcrowson pushed a commit to mcrowson/Flask-Fixtures that referenced this pull request Sep 7, 2016
Importing from flask.ext is deprecated
d361c98 
See changelog

https://github.com/pallets/flask/blob/master/CHANGES#L102
pallets/flask#1484
@mcrowson mcrowson mentioned this pull request Sep 7, 2016
Merged
@rleh rleh mentioned this pull request Jan 14, 2017
Merged
@imphil imphil mentioned this pull request Nov 19, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
willdrewesum referenced this pull request in tommyboytech/flask-mako Jul 18, 2023
@willdrewesum
complete fork
cfbd5a7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mitsuhiko mitsuhiko

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@untitaker @ThiefMaster @davidism @jeffwidman @mitsuhiko