This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add no-internal-module rule #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class NoInternalModuleWalker extends Lint.RuleWalker { | ||
| public visitModuleDeclaration(node: ts.ModuleDeclaration) { | ||
| let name = node.name.getText(); |
There was a problem hiding this comment.
I don't think you should look at the raw text here. The type of node.name is Identifier | LiteralExpression. So you should be able to simplify this to:
if (Lint.isNodeFlagSet(node, ts.NodeFlags.Namespace)) {
// ok namespace
} else if (node.name.syntaxKind === ts.SyntaxKind.Identifier) {
// for external modules, node.name will be a LiteralExpression instead of Identifier
this.addFailure(this.createFailure(node.getStart(), node.getWidth(), Rule.FAILURE_STRING));
}There was a problem hiding this comment.
cool! I added a commit.
There was a problem hiding this comment.
This name variable is no longer used. Linting should've picked that up, maybe it's a bug... Regardless, let's remove the let name...
11 tasks
vvakame
force-pushed
the
no-internal-module
branch
from
efc3458 to
39c3e92
Compare
|
sweet, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #513