Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5507] feat: namirial implementation in onboarding-crypto sdk #500

Merged
merged 10 commits into from
Sep 26, 2024
Merged

[SELC-5507] feat: namirial implementation in onboarding-crypto sdk #500

merged 10 commits into from
Sep 26, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Sep 24, 2024 •
edited
Loading

List of Changes

  • add namirial implementation
  • upgrade sdk version from 0.2.1 to 0.2.2

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

manuraf
manuraf reviewed Sep 24, 2024
View reviewed changes
libs/onboarding-sdk-crypto/pom.xml Outdated Show resolved Hide resolved
libs/onboarding-sdk-crypto/pom.xml Outdated Show resolved Hide resolved
libs/onboarding-sdk-crypto/pom.xml Outdated Show resolved Hide resolved
@giulia-tremolada giulia-tremolada marked this pull request as ready for review September 25, 2024 08:39
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner September 25, 2024 08:39
@github-actions github-actions bot added functions Changes are related to functions onboarding-ms labels Sep 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@giulia-tremolada giulia-tremolada merged commit 06f4e97 into main Sep 26, 2024
9 of 10 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-5507 branch September 26, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunzip gunzip gunzip left review comments

@manuraf manuraf manuraf approved these changes

Assignees
No one assigned
Labels
docs functions Changes are related to functions libs onboarding-ms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giulia-tremolada @gunzip @manuraf