Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoMethodError - undefined method `indifferent_params' with sinatra v2.0.0 #2132

Closed
sue445 opened this issue May 7, 2017 · 5 comments
Closed

NoMethodError - undefined method `indifferent_params' with sinatra v2.0.0 #2132

sue445 opened this issue May 7, 2017 · 5 comments

Comments

@sue445
Copy link
Contributor

sue445 commented May 7, 2017 •
edited
Loading

Do you want to request a feature or report a bug?

bug

What is the current behavior?

Gemfile

gem "padrino", "0.14.0.1"
gem "sinatra", "2.0.0"

When boot padrino and access any action, padrino is crashed!

bundle exec padrino s

(snip)

2017-05-08 01:00:17 - NoMethodError - undefined method `indifferent_params' for #<Sebastian::App:0x007fb6600492f0>:
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/padrino-core-0.14.0.1/lib/padrino-core/application/routing.rb:933:in `dispatch!'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/sinatra-2.0.0/lib/sinatra/base.rb:923:in `block in call!'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/sinatra-2.0.0/lib/sinatra/base.rb:1073:in `block in invoke'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/sinatra-2.0.0/lib/sinatra/base.rb:1073:in `catch'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/sinatra-2.0.0/lib/sinatra/base.rb:1073:in `invoke'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/sinatra-2.0.0/lib/sinatra/base.rb:923:in `call!'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/sinatra-2.0.0/lib/sinatra/base.rb:913:in `call'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/rollbar-2.14.1/lib/rollbar/middleware/rack.rb:20:in `block in call'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/rollbar-2.14.1/lib/rollbar.rb:145:in `scoped'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/rollbar-2.14.1/lib/rollbar/middleware/rack.rb:18:in `call'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/lib/connection_pool_management_middleware.rb:7:in `block in call'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/vendor/bundle/ruby/2.4.0/gems/activerecord-5.1.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:408:in `with_connection'
	/Users/sue445/dev/workspace/github.com/sue445/sebastian-badge/lib/connection_pool_management_middleware.rb:7:in `call'

What is the expected behavior?

no error

Which versions of Ruby, Padrino, Sinatra, Rack, OS are you using? Did this work in previous versions?

  • Ruby: 2.4.1
  • Padrino: 0.14.0.1
  • Sinatra: 2.0.0
  • Rack: 2.0.1
  • OS: OSX 10.9.5

Did this work in previous versions?

Sinatra 2.0.0.rc2 is no problem.

I think this is affecting.
sinatra/sinatra#1279
@ujifgc ujifgc closed this as completed in a3ea63b May 8, 2017
@ujifgc
Copy link
Member

ujifgc commented May 8, 2017

Thank you for your report.

@vuhailuyen1991
Copy link

Same issue after upgrading sinatra to 2.0

@faustoct1
Copy link

faustoct1 commented May 22, 2017 •
edited
Loading

Any idea when to add padrino on top of more recent sinatra version ? using the most recent version 2.0.0.rc6 doesn't work but 2.0.0.rc2 works fine. Any idea whether still working in future versions?

@faustoct1 faustoct1 mentioned this issue May 22, 2017
Merged
@wikimatze
Copy link
Member

Hi @faustoct, we have to checkout what is failing and then try to use the version in a further release.

@faustoct1
Copy link

working now padrino 0.14.0.2

adam12 pushed a commit to adam12/padrino-framework that referenced this issue Jun 5, 2017
@ujifgc @adam12
use Sinatra2 IndifferentHash if available, fixes padrino#2132
b7fe36a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ujifgc @wikimatze @sue445 @faustoct1 @vuhailuyen1991