Fix weird directory ... not found
#3
Conversation
It turns out some OSs have `sh` linked to other kinds of shells, that are not `bash`. For example, Ubuntu uses `dash` (ref: https://wiki.ubuntu.com/DashAsBinSh). Some of those shells do not provide the built-in command `source`, which causes the function `JumpCommand` to fail with an 127 error code. Since `jump.vim` assumes all errors are caused by non-existing directories, the resulting error message was very enigmatic and frustrating…
|
@abravalheri thank you for your contribution! Good catch, I stumbled across this in another project too. I personally don't have Thank you! |
|
Hi @padde, unfortunatelly it doesn't seem to be that simple, at least in Ubuntu. Just replacing: - return system("bash -c 'source " . g:autojump_executable . " && " . a:cmd . " " . a:args . " > /dev/null && pwd'")
+ return system("sh -c '. " . g:autojump_executable . " && " . a:cmd . " " . a:args . " > /dev/null && pwd'")still generates a 127 error. + return system("bash -c '. " . g:autojump_executable . " && " . a:cmd . " " . a:args . " > /dev/null && pwd'")works though By checking |
|
Oh well if we depend on |
Hi @padde thank you very much for the amazing plugin!
I have being using it for a while now, but in the last weeks when I switched operating system, I have been dealing with a very weird
directory ... not found error(when the directory does exist).It turns out, some OSs have
shlinked to other kinds of shells, that are notbash-like. For example, Ubuntu usesdash(ref: https://wiki.ubuntu.com/DashAsBinSh).Some of those shells do not provide the built-in command
source, which causesthe function
JumpCommandto fail with an 127 error code.Since
jump.vimassumes all errors are caused by non-existing directories,the resulting error message was very enigmatic and frustrating…
This PR, tries to solve that by enforcing
bash, that is pretty much present every where. While it is not ideal to assumebashis omnipresent, we cannot assume all built-inshsupport thesourcecommand either :(This would be the best compromise I think (especially considering for example that Ubuntu is quite popular).