Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ruby-standalone 1.8.0 and move pact details from the POST /pact call to the command line #50

Closed
1 task done
mefellows opened this issue Oct 17, 2017 · 1 comment
Closed
1 task done

Update to ruby-standalone 1.8.0 and move pact details from the POST /pact call to the command line #50

mefellows opened this issue Oct 17, 2017 · 1 comment
Assignees
@mefellows

Comments

@mefellows
Copy link
Member

mefellows commented Oct 17, 2017 •
edited
Loading

@bethesque commented on Wed Oct 04 2017

Instead of posting the consumer name, provider name, and pact file write mode in the POST /pact call here https://github.com/pact-foundation/pact-js/blob/master/src/dsl/mockService.js#L75, they should now be passed in to the command line service call using --consumer, --provider and --pact-file-write-mode

TODO:

  • add pact-file-write-mode to this package
@mefellows mefellows self-assigned this Dec 9, 2017
mefellows added a commit that referenced this issue Dec 10, 2017
@mefellows
feat(pactFileWriteMode): add pactFileWriteMode to server. Fixes #50
2a6e2f5
@mefellows mefellows mentioned this issue Dec 10, 2017
Merged
mefellows added a commit that referenced this issue Dec 10, 2017
@mefellows
feat(pactFileWriteMode): add pactFileWriteMode to server. Fixes #50
c3cfa76
mefellows added a commit that referenced this issue Dec 10, 2017
@mefellows
feat(pactFileWriteMode): add pactFileWriteMode to server. Fixes #50
bb54457
mefellows added a commit that referenced this issue Dec 10, 2017
@mefellows
feat(pactFileWriteMode): add pactFileWriteMode to server. Fixes #50
0f8658b
@mefellows
Copy link
Member Author

Pull request for this. See #66.

mefellows added a commit that referenced this issue Dec 10, 2017
@mefellows
Merge pull request #66 from pact-foundation/feat/50-pactFileWriteMode
b1a3927 
feat(pactFileWriteMode): add pactFileWriteMode to server. Fixes #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mefellows mefellows

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mefellows