fix: set strictSSL on custom downloads from NPM config. Fixes #211

pact-foundation · Mar 6, 2020 · d264f0b · d264f0b
1 parent efa9d9c
commit d264f0b
Show file tree

Hide file tree

Showing 4 changed files with 90 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -57,6 +57,7 @@
     "chalk": "2.3.1",
     "check-types": "7.3.0",
     "cross-spawn": "^7.0.1",
+    "libnpmconfig": "^1.2.1",
     "mkdirp": "0.5.1",
     "q": "1.5.1",
     "request": "2.87.0",

diff --git a/standalone/install.spec.ts b/standalone/install.spec.ts
@@ -4,7 +4,7 @@
 import * as fs from 'fs';
 import * as path from 'path';
 import * as chai from 'chai';
-import { BinaryEntry, Config } from './install';
+import { BinaryEntry, Config, useStrictSSL } from './install';
 
 const expect = chai.expect;
 
@@ -19,6 +19,27 @@ describe('Install', () => {
     }
   });
 
+  describe('#useStrictSSL', () => {
+    afterEach(() => {
+      delete process.env['npm_config_strict-ssl']
+    })
+    describe('when "strict-ssl" is specified in an NPM configuration', () => {
+      it('returns a true', () => {
+        process.env['npm_config_strict-ssl'] = "true"
+        expect(useStrictSSL()).to.be.true
+      })
+      it('returns a false', () => {
+        process.env['npm_config_strict-ssl'] = "false"
+        expect(useStrictSSL()).to.be.false
+      })
+    })
+    describe('when "strict-ssl" is not specified in any NPM configuration', () => {
+      it('returns true', () => {
+        expect(useStrictSSL()).to.be.true
+      })
+    })
+  })
+
   function createConfig(): Config {
     return require('./install').createConfig();
   }

diff --git a/standalone/install.ts b/standalone/install.ts
@@ -3,12 +3,14 @@ import * as Request from 'request';
 import unzipper = require('unzipper');
 import tar = require('tar');
 import pactEnvironment from '../src/pact-environment';
-// we have to u se ES6 imports as it's providing correct types for chalk.
+// we have to use ES6 imports as it's providing correct types for chalk.
 import chalk from 'chalk';
-
 import path = require('path');
 import fs = require('fs');
 import urljoin = require('url-join');
+
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const config = require('libnpmconfig')
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const sumchecker = require('sumchecker');
 
@@ -142,6 +144,11 @@ const CIs = [
 	'WERCKER_ROOT',
 ];
 
+export function useStrictSSL(): boolean {
+	const prop = config.read()['strict-ssl']
+	return prop === "true" || prop === undefined || prop === ""
+}
+
 function downloadFileRetry(
 	url: string,
 	filepath: string,
@@ -157,6 +164,7 @@ function downloadFileRetry(
 				headers: {
 					'User-Agent': 'https://github.com/pact-foundation/pact-node',
 				},
+				strictSSL: useStrictSSL()
 			})
 				.on('error', (e: string) => reject(e))
 				.on(