fix(options): Stop validating values for logLevel, pactFileWriteMode …

…and format. This means we'll immediately pick up changes to those options without needing to modify pact-node
pact-foundation · May 4, 2020 · 1319a86 · 1319a86
1 parent 30364fd
commit 1319a86
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 44 deletions.
diff --git a/src/message.ts b/src/message.ts
@@ -76,11 +76,6 @@ export class Message {
 			checkTypes.assert.string(options.provider);
 		}
 
-		checkTypes.assert.includes(
-			['overwrite', 'update', 'merge'],
-			options.pactFileWriteMode,
-		);
-
 		this.options = options;
 	}
 

diff --git a/src/server.spec.ts b/src/server.spec.ts
@@ -93,24 +93,6 @@ describe('Server Spec', () => {
 					}),
 				).to.throw(Error);
 			});
-
-			it('should fail if incorrect pactFileWriteMode provided', () => {
-				expect(() =>
-					serverFactory({
-						pactFileWriteMode: 'notarealoption',
-						// eslint-disable-next-line @typescript-eslint/no-explicit-any
-					} as any),
-				).to.throw(Error);
-			});
-
-			it('should fail if incorrect logLevel provided', () => {
-				expect(() =>
-					serverFactory({
-						logLevel: 'nolog',
-						// eslint-disable-next-line @typescript-eslint/no-explicit-any
-					} as any),
-				).to.throw(Error);
-			});
 		});
 
 		context('when valid options are set', () => {

diff --git a/src/server.ts b/src/server.ts
@@ -57,17 +57,8 @@ export class Server extends AbstractService {
 			checkTypes.assert.string(options.provider);
 		}
 
-		checkTypes.assert.includes(
-			['overwrite', 'update', 'merge'],
-			options.pactFileWriteMode,
-		);
-
 		if (options.logLevel) {
 			options.logLevel = options.logLevel.toLowerCase() as LogLevel;
-			checkTypes.assert.includes(
-				['debug', 'info', 'warn', 'error'],
-				options.logLevel,
-			);
 		}
 
 		if (options.monkeypatch) {

diff --git a/src/verifier.spec.ts b/src/verifier.spec.ts
@@ -225,17 +225,6 @@ describe('Verifier Spec', () => {
 			).to.throw(Error);
 		});
 
-		it('should throw an error with the wrong string', () => {
-			expect(() =>
-				verifierFactory({
-					providerBaseUrl: 'http://localhost',
-					pactUrls: ['http://idontexist'],
-					format: 'jsonformat',
-					// eslint-disable-next-line @typescript-eslint/no-explicit-any
-				} as any),
-			).to.throw(Error);
-		});
-
 		it('should work with a case insensitive string', () => {
 			expect(() =>
 				verifierFactory({

diff --git a/src/verifier.ts b/src/verifier.ts
@@ -214,7 +214,6 @@ export class Verifier {
 
 		if (options.format) {
 			checkTypes.assert.string(options.format);
-			checkTypes.assert.match(options.format, /^(xml|json|progress)$/i);
 			if (options.format.toLowerCase() === 'xml') {
 				options.format = 'RspecJunitFormatter';
 			}