feat: Add new branch consumerVersionSelector options to verifier #343
Conversation
|
|
||
| expect( | ||
| warnSpy.calledWith( | ||
| "Using the tag 'latest' is not recommended and probably does not do what you intended." |
There was a problem hiding this comment.
I'm unsure about having the tests rely on the exact logger output, but I can't think of a nicer way to do this - and I do like that the warning is tested.
There was a problem hiding this comment.
Normally I'd agree with you. Testing log output gives me the shudders. I thought that given the "latest" tag behaviour gives output to the consumers that is quite key, then it may be worth doing something minor like this :)
|
This is excellent, thank you so much! I'm happy to merge this, but haven't because it was marked as draft (I'm not sure if you just meant "draft until someone reviews") If you have the time, it would be excellent to get this ported into the |
|
I've approved the tests, but they currently fail on PR runs due to a git issue - so don't worry when that happens. |
How is the |
|
Yes, that’s exactly right. There are a few breaking changes so it’s hard to cherry pick across. I think in pact-node this is just a typescript type change. We intended it to be short lived, but that wasn’t the way things worked out with the uplift to the rust core |
This implements the pact-js-core side of issue pact-foundation/pact-js#757