You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Additionally, the error message Couldn't stop Pact and Couldn't start Pact would be much more helpful if they specified that there was a timeout while waiting for Pact.
The text was updated successfully, but these errors were encountered:
Software versions
Issue Checklist
Please confirm the following:
Expected behaviour
When a
timeout
is given to the options inpactWith(options)
, the pact timeout changes.Actual behaviour
Jest-Pact's timeout option correctly changes Jest's timeout, but does not change Pact's wait-for-service timeout.
Steps to fix
Jest-Pact doesn't pass on the actual timeout given to pact, because it's not on the options object here:
https://github.com/pact-foundation/pact-js-core/blob/master/src/service.ts#L331
It would then need to be used anywhere that
PROCESS_TIMEOUT
is used, eg:https://github.com/pact-foundation/pact-js-core/blob/master/src/service.ts#L183
and
https://github.com/pact-foundation/pact-js-core/blob/master/src/service.ts#L208
Additionally, the error message
Couldn't stop Pact
andCouldn't start Pact
would be much more helpful if they specified that there was a timeout while waiting for Pact.The text was updated successfully, but these errors were encountered: