Skip to content

Commit

Permalink
fix: add disableSslVerification option to verifier
Browse files Browse the repository at this point in the history
  • Loading branch information
TimothyJones committed Sep 9, 2021
1 parent 92f0532 commit f354d8a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/verifier/arguments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@ export const ignoredArguments = [
'validateSSL',
];

export const argMapping: ArgMapping<
VerifierOptions & DeprecatedVerifierOptions
> = {
export const argMapping: ArgMapping<VerifierOptions &
DeprecatedVerifierOptions> = {
providerBaseUrl: (providerBaseUrl: string) => {
const u = url.parse(providerBaseUrl);
return u && u.port && u.hostname
Expand Down Expand Up @@ -77,8 +76,8 @@ export const argMapping: ArgMapping<
publishVerificationResult: { arg: '--publish', mapper: 'flag' },
enablePending: { arg: '--enable-pending', mapper: 'flag' },
timeout: { arg: '--request-timeout', mapper: 'string' },

// We should support these, I think
disableSslVerification: { arg: '--disable-ssl-verification', mapper: 'flag' },
// We should support these in the future, I think
format: {
warningMessage:
"All output is now on standard out, setting 'format' has no effect",
Expand All @@ -100,7 +99,6 @@ export const argMapping: ArgMapping<
warningMessage:
'The undocumented feature monkeypatch is no more, please file an issue if you were using it and need this functionality',
},
// Todo in Rust ?
customProviderHeaders: {
warningMessage:
'customProviderHeaders have been removed. This functionality is provided by request filters in a much more flexible way',
Expand Down
1 change: 1 addition & 0 deletions src/verifier/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@ export interface VerifierOptions {
consumerVersionSelectors?: ConsumerVersionSelector[];
timeout?: number;
logLevel?: LogLevel;
disableSslVerification?: boolean;
}

0 comments on commit f354d8a

Please sign in to comment.