feat: allow configuration of host #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bewatts looks good, did you have a chance to test it against your project? I mean to link the package to your project |
|
No, I've been flailing on convincing my nest app to use the nestjs-pact version from my branch, unsuccessfully. At this point, I'm tempted to say we should just merge it? It's potentially useful beyond my usecase, even if it doesn't work for me. What do you think? |
3 tasks
|
Hey guys, what's the status on this PR? I could really use this feature as nest is using an IPv6 IP address by default, but when running the pact test on my remote container, it's not picking up the connection. It works if I manually edit the Edit: clarified a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows configuring of host for the provider. I'm still verifying that this fixes my problem, so let's not merge this until I can verify.
Motivation and Context
I'm having an issue running nestjs-pact in CI. See this thread for more information.
This should fix: #12
How Has This Been Tested?
Yes, tested by mocking what app.listen recieves.
Mac M1, ran all tests.
Expands the options type that nestjs-pact accepts.
Types of changes
Checklist: