send_to_port and mirror_packet arguments should be in direction #110
Conversation
I noticed this while testing a front-end change for compile time known-constants fix. These arguments should not be directionless and not required to be a compile time known constants. Signed-off-by: Andrew Pinski <apinski@marvell.com>
|
Hi @apinski-cavium, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes: ✒️ 👉 https://cla.opennetworking.org After signing, make sure to add your Github user ID For more information or help:" |
|
I should note this was found while implementing p4lang/p4-spec#1213 into a front-end. |
We all missed it before the release in December. Also the examples only use send_to_port/mirror_packet from an action where the argument was from the table/control plane (and p4c has a bug there which allows it) which allowed this to missed by the examples also. Basically I am saying things slip through everyone's eyes even. |
I noticed this while testing a front-end change for compile time known-constants fix.
These arguments should not be directionless and not required to be a compile time known constants.
Signed-off-by: Andrew Pinski apinski@marvell.com