Add metadata bytes field #271
Conversation
|
LGTM |
There was a problem hiding this comment.
The change LGTM. I am in favor of not changing the cookie field in ForwardingPipelineConfig as the only use case we have for it at the moment is as a client-provided identifier for the pipeline configuration, for which a uint64 seems sufficient. We can change it in the future if required, but it seems there is no need to make that change now and make the interface more complex.
@stefanheule could you update the "Revision History" section as part of this change (https://p4.org/p4runtime/spec/master/P4Runtime-Spec.html#sec-changes-in-v120-under-development), it will make the releasing process easier for me for 1.2.0.
docs/v1/P4Runtime-Spec.mdk
Outdated
| target. There is no requirement of where this is stored, but it must be | ||
| returned by the server along with the rest of the entry when the client | ||
| performs a read on the entry. This is deprecated in favor of the more flexible | ||
| metadata field. |
There was a problem hiding this comment.
| metadata field. | |
| `metadata` field. |
There was a problem hiding this comment.
I did both, thanks.
Fixes #267.