Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve P4Runtime Value Set support #157

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

antoninbas
Copy link
Member

The objectives of this change is to:

  • cover more cases supported by the P4_16 spec
  • provide more intuitive runtime programming
  • be more future-proof to reduce the potential changes in future
    P4Runtime versions

In particular, we now support structs with bit members as the type
parameter for value_set. The members of the struct may have different
match types.

Fixes #135
Fixes #134

@jafingerhut
Copy link
Contributor

While I could approve this, it seems best to me if at least one other person besides Antonin and I review this. If you want me to approve it so it can be merged in without someone else's review, let me know and I can do that, as I have read it in detail and it looks good to me.

@antoninbas
Copy link
Member Author

@jafingerhut I'm working on scheduling a P4 API WG meeting next Wednesday at the usual time slot to discuss the other outstanding issues
My plan is to bring this up at the meeting and not to merge this PR until after the meeting

The objectives of this change is to:
 * cover more cases supported by the P4_16 spec
 * provide more intuitive runtime programming
 * be more future-proof to reduce the potential changes in future
   P4Runtime versions

In particular, we now support structs with bit<W> members as the type
parameter for value_set. The members of the struct may have different
match types.

Fixes #135
Fixes #134
@antoninbas antoninbas force-pushed the antonin/improve-value-set-support branch 2 times, most recently from 0582e6e to f5396e5 Compare January 23, 2019 01:16
@antoninbas antoninbas force-pushed the antonin/improve-value-set-support branch from f5396e5 to d986bf6 Compare January 23, 2019 01:19
@antoninbas antoninbas merged commit 5214037 into master Jan 23, 2019
@antoninbas antoninbas deleted the antonin/improve-value-set-support branch January 23, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants