Clean up the P4-14 dependent code. #4925
Conversation
fruffy
added
the
core
fruffy
force-pushed
the
fruffy/p4_14_refactor
branch
2 times, most recently
from
c027db9 to
da3cef8
Compare
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/p4_14_refactor
branch
from
da3cef8 to
3afcf84
Compare
| @@ -165,8 +165,10 @@ bool ToP4::preorder(const IR::P4Program *program) { | |||
| if (sourceFile.startsWith(p4includePath)) { | |||
| const char *p = sourceFile.c_str() + strlen(p4includePath); | |||
| if (*p == '/') p++; | |||
| // TODO: This is v1model-specific code. This should be not part of the core | |||
There was a problem hiding this comment.
With #4899 we can likely get rid of this code and move it into the bmv2 back end.
|
We also have a P4-16 implementation of the v1model (p4include/v1model.p4). I'm not sure how many of the declarations you've moved are used by v1model.p4, but is the expectation that these won't compile if the P4-14 code is excluded? |
The code doesn't seem to be used much in the P4-16 parts except for the constants in But I do not know how Tofino depends on the code here. |
First attempt to make P4-14 specific code optional in the compiler. This can make it a little easier to reason about IR changes and might reduce compile times, too.
The goal is to remove all "v1model"-specific code from the compiler core and move it into the appropriate folders. What makes this change a little tedious is that https://github.com/p4lang/p4c/blob/main/frontends/p4/fromv1.0/v1model.h is a bunch of constant strings that are referenced by the control plane and the toP4 pass.
In subsequent PRs, I will try to find a replacement for this file.