Test building P4C with ENABLE_GTESTS=OFF in CI
#4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The building issues reported in #4715 can be caught by the updated CI, as expected:
|
fruffy
reviewed
Jun 11, 2024
.github/workflows/ci-test-debian.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| gtest: [ON, OFF] |
There was a problem hiding this comment.
We unfortunately have limited CI resources, the more tests we add the slower they run. I would fold this into the UNITY=OFF test run, i.e, disable GTEST when we do not use a Unity build.
fruffy
added
the
infrastructure
fruffy
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4715, some building issues with
ENABLE_GTESTS=OFFhave been identified. Adding this variation in CI can help catch such issues early on in the future.