Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P4TC - Support for DirectCounter extern #4711

Merged
merged 12 commits into from
Jun 11, 2024
Merged

P4TC - Support for DirectCounter extern #4711

merged 12 commits into from
Jun 11, 2024

Conversation

komaljai
Copy link
Contributor

@komaljai komaljai commented Jun 6, 2024

No description provided.

@komaljai komaljai added the p4tc Topics related to the P4-TC back end label Jun 6, 2024
@fruffy fruffy added the run-sanitizer Use this tag to run a Clang+Sanitzers CI run. label Jun 6, 2024
vbnogueira
vbnogueira reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@vbnogueira vbnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round

testdata/p4tc_samples_outputs/direct_counter_example.template Outdated Show resolved Hide resolved
testdata/p4tc_samples_outputs/direct_counter_example.template Outdated Show resolved Hide resolved
@komaljai komaljai force-pushed the support_direct_counter branch from 17aeee5 to bd3a3fd Compare June 10, 2024 13:47
Sosutha
Sosutha approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@Sosutha Sosutha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@Sosutha Sosutha added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@komaljai komaljai added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@komaljai komaljai added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@komaljai komaljai added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@komaljai komaljai added this pull request to the merge queue Jun 11, 2024
@fruffy
Copy link
Collaborator

fruffy commented Jun 11, 2024

The merge here will likely fail, I will requeue once I reconfigured the CI tests.

Merged via the queue into p4lang:main with commit 69e4ac6 Jun 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbnogueira vbnogueira vbnogueira left review comments

@Sosutha Sosutha Sosutha approved these changes

Assignees
No one assigned
Labels
p4tc Topics related to the P4-TC back end run-sanitizer Use this tag to run a Clang+Sanitzers CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@komaljai @fruffy @Sosutha @vbnogueira