Distinct subdirectory in docs/README.md #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanw
approved these changes
Apr 9, 2017
hanw
previously requested changes
Apr 9, 2017
ChrisDodd
reviewed
Apr 9, 2017
docs/README.md
Outdated
| @@ -8,7 +8,7 @@ The code and documentation are hosted in the following repository: https://githu | |||
| ``` | |||
| p4c | |||
| ├── build -- recommended place to build binary | |||
| ├── p4include -- standard P4 files needed by the compiler | |||
| ├── p4include -- standard P4 files needed by the compiler (e.g., core.p4) | |||
| ├── backends | |||
There was a problem hiding this comment.
Keep this in alphabetical order? Makes it easier to avoid accidental duplication.
|
@hanw I am a student in BUPT, who is a institutional member of P4.org. |
qin-nz
commented
Apr 10, 2017
docs/README.md
Outdated
| ├── frontends | ||
| │ ├── common -- common front-end code | ||
| │ ├── p4-14 -- P4_14 front-end | ||
| │ └── p4 -- P4_16 front-end | ||
| ├── ir -- core internal representation | ||
| ├── lib -- common utilities (libp4toolkit.a) | ||
| ├── m4 |
There was a problem hiding this comment.
@hanw I am not sure what m4 means.
There was a problem hiding this comment.
M4 is a preprocessing system. See http://www.gnu.org/software/m4/m4.html.
|
@hanw: Maybe we can accept this one? |
cc10512
approved these changes
Apr 12, 2017
cc10512
dismissed
hanw’s stale review
changes addressed. @hanw is currently at the beach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.