Hi @chrispsommers, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID chrispsommers to the agreement.

For more information or help:"
https://wiki.opennetworking.org/x/BgCUI

The nanomsg installation is failing for Ubuntu 18. We may consider disable P4Testgen support for this particular CI run.

I noticed that docker build under Ubuntu 18.04 fails after adding p4toolks to the build. It looks like lack of Python support in older distros. https://github.com/p4lang/p4c/actions/runs/5384634043/jobs/9772783270?pr=4049

It would be a shame to suppress routine docker build/publish of p4tools because it fails in an older OS. Any opinions on how to proceed? I could experiment with docker build-args to suppress building p4tools for older images which don't support it.

I noticed that docker build under Ubuntu 18.04 fails after adding p4toolks to the build. It looks like lack of Python support in older distros. https://github.com/p4lang/p4c/actions/runs/5384634043/jobs/9772783270?pr=4049

It would be a shame to suppress routine docker build/publish of p4tools because it fails in an older OS. Any opinions on how to proceed? I could experiment with docker build-args to suppress building p4tools for older images which don't support it.

Yes, this is part of a discussion here #3986. Technically, we do not need nanomsg, which is the installation that is failing. But P4Tools has never been tested on Ubuntu 18.04 and I believe that is not the only problem. What we can do is to disable building P4Tools for Ubuntu 18.04 here:
https://github.com/p4lang/p4c/blob/main/tools/ci-build.sh#L82

What we can do is to disable building P4Tools for Ubuntu 18.04 here:
https://github.com/p4lang/p4c/blob/main/tools/ci-build.sh#L82

Thanks! I came to the same conclusion about where to disable p4tools build for 18.04 and am testing a fix now. Fortunately, the Dockerfile already parameterized everything with ARG so it's a simple thing to change.

Great! The size increase makes sense. The P4Tools framework is rather large and pulls in a dependencies such as Z3.

@fruffy Thanks for the quick review! Hopefully, this lowers the barrier to experimentation and adoption of p4testgen. Thanks @jafingerhut for encouraging me to submit this.