Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow constructor calls of externs with abstract methods #3460

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Do not allow constructor calls of externs with abstract methods #3460

merged 1 commit into from
Jul 27, 2022

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu mbudiu@vmware.com

@mihaibudiu mihaibudiu requested a review from rst0git July 25, 2022 19:03
@mihaibudiu
Copy link
Contributor Author

Fixes #3282

Do not allow constructor calls of externs with abstract methods
5c68381 
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
@mihaibudiu mihaibudiu requested a review from fruffy July 26, 2022 17:36
rst0git
rst0git approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git rst0git merged commit 9e2af60 into p4lang:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rst0git rst0git rst0git approved these changes

@fruffy fruffy fruffy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaibudiu @fruffy @rst0git