Update BUILD.bazel to remove constat patterns from glob #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constant patterns in glob can be error-prone, moving the files outside the globs.
mihaibudiu
reviewed
Jun 22, 2022
| "backends/dpdk/*.cpp", | ||
| "backends/dpdk/control-plane/*.cpp", | ||
| ], | ||
| exclude = [ |
There was a problem hiding this comment.
so the patterns in exclude, which are constant, but inside glob, are not a problem?
There was a problem hiding this comment.
The issue with the default include=[] is that constant patterns such as the backends/bmv2/common/lower.cpp, will be silently ignored if the file is not available.
mihaibudiu
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant patterns in glob can be error-prone,
moving the files outside the globs.