Unifying struct and list expressions fix (#3057) #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
requested changes
Mar 12, 2022
| @@ -0,0 +1,6 @@ | |||
| issue3057-1.p4(11): [--Werror=type-error] error: ==: cannot compare initializers with unknown types | |||
There was a problem hiding this comment.
this message isn't very good. I know you didn't change this, but perhaps you can fix it.
The message should say "cannot compare structure-valued expressions with unknown types".
There was a problem hiding this comment.
I expect that you will need to change these reference files now that the error message has changed.
mihaibudiu
reviewed
Mar 12, 2022
|
Hi, @mbudiu-vmw, I implemented the small changes you requested. |
… and structs p4lang#3057 * I corrected the code so that the compiler bug does not occur when comparing structures of unknown type, but to report an error * I enabled a comparison between the structure/list expression so that the cast can be put on either side. Before this change, if the cast was on the right side of the comparison operator error was reported. * Added tests which verify the above
|
Hi @mbudiu-vmw, I implemented the changes you requested, but I forgot to change the output in the test, now I did it too. |
mihaibudiu
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifying struct and list expressions fix (#3057)
I corrected the code so that the compiler bug does not occur when comparing structures of unknown type, but to report an error
I enabled a comparison between the structure/list expression so that the cast can be put on either side. Before this change, if the cast was on the right side of the comparison operator error was reported.
Added tests which verify the above
bool b2 = { a = 8w1, b = 8w2 } == { a = 8w1, b = 8w2 };
bool b21 = { a = 32w1, b = 32w2 } == { a = 32w1, b = 32w2 };
bool b3 = { a = 1, b = 2 } == {1, 2};
It is not logical that mockery is possible if we do not put a cast on one of the sides
Because what if we had two structures
struct S {
bit<32> a;
bit<32> b;
}
struct Q {
bit<32> a;
bit<32> b;
}
or in an even worse case, we do not have a single structure defined.
bool b5_ = { a = 1, b = 2 } == (S) { a = 1, b = 2 };
I enabled a comparison between the structure/list expression so that the cast can be put on either side. Before this change, if the cast was on the right side of the comparison operator error was reported.