v1model metadata preservation updates #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method Several updates to documentation in comments in v1model.p4, and in comments of one of the test programs demonstrating these features, now that the new method using the @field_list annotation has been merged.
|
Some of this is simply reforming paragraphs to fit within 72/80 column width, which I know is annoying to review, but I do believe it makes it easier to read, and for comments, people reading them is their primary purpose. Also several replacements of the old names to new names, e.g. recirculate->recirculate_preserving_field_list I also updated a fair number of comments, but only comments, in one of the v1model test programs that exercises recirculate, resubmit, and clone heavily. |
|
Pinging @smolkaj @kheradmandG who were involved in the p4c changes that led to these documentation changes, to see if they have any comments or suggestions here. |
mihaibudiu
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.