The back ends (uBPF, eBPF, DPDK) should not be compiled or run tests if they are missing their dependencies. #4535
Comments
fruffy
added
enhancement
|
Yes some tests for the backend like eBPF and uBPF fails, when I ran |
|
What is the output of the failures with |
|
ctest --output-on-failure -R ebpf/ 2/28 Test 281: ebpf/testdata/p4_16_samples/action_call_table_ebpf.p4 ...***Failed 0.53 sec 3/28 Test 282: ebpf/testdata/p4_16_samples/advance_ebpf.p4 .............***Failed 0.55 sec 4/28 Test 283: ebpf/testdata/p4_16_samples/bool_ebpf.p4 ................***Failed 0.52 sec 5/28 Test 284: ebpf/testdata/p4_16_samples/count_add_ebpf.p4 ...........***Failed 0.50 sec 6/28 Test 285: ebpf/testdata/p4_16_samples/count_ebpf.p4 ...............***Failed 0.54 sec 7/28 Test 286: ebpf/testdata/p4_16_samples/hit_ebpf.p4 .................***Failed 0.52 sec 8/28 Test 287: ebpf/testdata/p4_16_samples/init_ebpf.p4 ................***Failed 0.51 sec 9/28 Test 288: ebpf/testdata/p4_16_samples/issue2791_ebpf.p4 ...........***Failed 0.49 sec 10/28 Test 289: ebpf/testdata/p4_16_samples/issue2793_ebpf.p4 ...........***Failed 0.53 sec 11/28 Test 290: ebpf/testdata/p4_16_samples/issue2797_ebpf.p4 ...........***Failed 0.50 sec 12/28 Test 291: ebpf/testdata/p4_16_samples/issue2816-1_ebpf.p4 .........***Failed 0.55 sec 13/28 Test 292: ebpf/testdata/p4_16_samples/issue2816_ebpf.p4 ...........***Failed 0.55 sec 14/28 Test 293: ebpf/testdata/p4_16_samples/issue870_ebpf.p4 ............***Failed 0.63 sec 15/28 Test 294: ebpf/testdata/p4_16_samples/key-issue-1020_ebpf.p4 ......***Failed 0.61 sec 16/28 Test 295: ebpf/testdata/p4_16_samples/key_ebpf.p4 .................***Failed 0.53 sec 17/28 Test 296: ebpf/testdata/p4_16_samples/length_ebpf.p4 ..............***Failed 0.53 sec 18/28 Test 297: ebpf/testdata/p4_16_samples/lpm_ebpf.p4 ................. Passed 0.57 sec 20/28 Test 299: ebpf/testdata/p4_16_samples/switch_ebpf.p4 ..............***Failed 0.53 sec 21/28 Test 300: ebpf/testdata/p4_16_samples/ternary_ebpf.p4 ............. Passed 0.52 sec 23/28 Test 302: ebpf/testdata/p4_16_samples/two_ebpf.p4 .................***Failed 0.57 sec 24/28 Test 303: ebpf/testdata/p4_16_samples/valid_ebpf.p4 ...............***Failed 0.57 sec 25/28 Test 304: ebpf/testdata/p4_16_samples/value_set_ebpf.p4 ...........***Failed 0.54 sec 26/28 Test 305: ebpf/testdata/p4_16_samples/verify_ebpf.p4 ..............***Failed 0.47 sec 27/28 Test 307: ebpf/testdata/p4_16_samples/ebpf_checksum_extern.p4 .....***Failed 0.60 sec 28/28 Test 308: ebpf/testdata/p4_16_samples/ebpf_conntrack_extern.p4 .... Passed 0.69 sec 11% tests passed, 25 tests failed out of 28 Label Time Summary: Total Test time (real) = 15.49 sec The following tests FAILED: |
|
Please format the comment so it does not accidentally reference other issues. But it looks like the failures are coming from pcap not being installed, so they are directly related to the problem in this issue. The eBPF back end tests should not be run if these dependencies are missing. |
|
I think I understood what needs to be done here, I would like to work on this issue. |
|
Can I work on this? |
|
Sure! The context of this issue is #4132. The packages should be part of the eBPF CMake instead. |
|
@fruffy I am planning to modify CMakeLists.txt for each backend and check for the dependencies, if any of the dependency is not present, we skip the test and give out a warning message I will make a module to check dependencies in the root CMakeLists.txt file and reuse it for general context. Should I go forward with this approach |
|
Yes, that sounds good! Make sure the return() works as intended. There is probably a couple more dependencies like that:
|
This is something that always throws of first-time users of the compiler. In particular when they run
ctestthey see a bunch of failing tests because runtime dependencies of these tests are missing.The text was updated successfully, but these errors were encountered: