feat: add parameter to customize token lifespan #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @endroca . 2 things:
|
xgp
requested changes
Nov 4, 2024
| return OptionalInt.empty(); | ||
| } | ||
|
|
||
| return OptionalInt.of(Integer.parseInt(lifespan)); |
There was a problem hiding this comment.
Should catch a NumberFormatException here, as the string doesn't get validated
There was a problem hiding this comment.
True, I didn't validate that... there are two approaches here: Forcing an unknown error for Keycloak and preventing login, or going with the default settings and logging an error.
I'm more inclined to use the default configuration. What do you think?
src/main/java/io/phasetwo/keycloak/magic/auth/MagicLinkAuthenticator.java
Show resolved
Hide resolved
src/main/java/io/phasetwo/keycloak/magic/auth/MagicLinkAuthenticatorFactory.java
Outdated
Show resolved
Hide resolved
xgp
requested changes
Nov 4, 2024
src/main/java/io/phasetwo/keycloak/magic/auth/MagicLinkAuthenticatorFactory.java
Outdated
Show resolved
Hide resolved
xgp
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.