Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set config default values before parse #525

Merged
merged 20 commits into from
Dec 21, 2023
Merged

Set config default values before parse #525

merged 20 commits into from
Dec 21, 2023

Conversation

DmitryRomanov
Copy link
Collaborator

Resolves #358

@DmitryRomanov DmitryRomanov force-pushed the 358-get-pipeline-config branch 2 times, most recently from 00f3ccc to 6ac7de3 Compare October 31, 2023 09:32
@DmitryRomanov DmitryRomanov force-pushed the 358-get-pipeline-config branch 5 times, most recently from ed29054 to 241350c Compare November 30, 2023 09:13
Dmitry Romanov and others added 19 commits December 14, 2023 19:28
@DmitryRomanov
setDefaultValues before DecodeConfig (ozontech#358)
45b6d45
@DmitryRomanov
get pipeline config (ozontech#358)
33f62a0
@DmitryRomanov
tests for bool default (ozontech#358)
a3f40bc
@DmitryRomanov
revert TestSlice in config (ozontech#358)
3c84d53
@DmitryRomanov
revert TestSlice in config (ozontech#358)
e462c10
@DmitryRomanov
fix TestSlice and add TestSliceBool (ozontech#358)
da29b42
@DmitryRomanov
open SetDefaultValues (ozontech#358)
3c7ce27
@DmitryRomanov
SetDefaultValues for slices (ozontech#358)
cb93b47
@DmitryRomanov
SetDefaultValues in test.NewConfig (ozontech#358)
69dfafe
@DmitryRomanov
fix SetDefaultValues for non struct data (ozontech#358)
e7801fc
@DmitryRomanov
dont ovverride true value by default (ozontech#358)
b5ac30f
@DmitryRomanov
fix tests (ozontech#358)
66c4025
@DmitryRomanov
fix linter errors and file.d_test (ozontech#358)
04475dd
@DmitryRomanov
fix TestThrottleNoLimit (ozontech#358)
65547bd
@DmitryRomanov
get config from pipeline package (ozontech#358)
7d68630
@DmitryRomanov
Revert "get config from pipeline package (ozontech#358)"
9ecd60c 
This reverts commit 0d1b94b.
@DmitryRomanov
parseFieldSelector in pipeline package (ozontech#358)
b7f641b
@DmitryRomanov
Revert "parseFieldSelector in pipeline package (ozontech#358)"
d930168 
This reverts commit ae2494f.
@DmitryRomanov
GetConfig in pipeline package (ozontech#358)
52a14dc
@DmitryRomanov DmitryRomanov force-pushed the 358-get-pipeline-config branch from 241350c to 52a14dc Compare December 14, 2023 12:28
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (7d1a963) 69.67% compared to head (52a14dc) 69.53%.

❗ Current head 52a14dc differs from pull request most recent head 34e99b7. Consider uploading reports for the commit 34e99b7 to get more accurate results

Files Patch % Lines
cfg/config.go 82.85% 8 Missing and 4 partials ⚠️
pipeline/config.go 40.00% 4 Missing and 2 partials ⚠️
test/test.go 40.00% 2 Missing and 1 partial ⚠️
fd/file.d.go 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   69.67%   69.53%   -0.15%     
==========================================
  Files         109      110       +1     
  Lines       11414    11428      +14     
==========================================
- Hits         7953     7946       -7     
- Misses       2976     3000      +24     
+ Partials      485      482       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryRomanov DmitryRomanov merged commit 7b62678 into ozontech:master Dec 21, 2023
8 checks passed
@DmitryRomanov DmitryRomanov deleted the 358-get-pipeline-config branch December 21, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimalekseev vadimalekseev vadimalekseev approved these changes

@HeadHunter483 HeadHunter483 HeadHunter483 approved these changes

@vano144 vano144 vano144 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Support 'default' tag for the booleans
4 participants
@DmitryRomanov @vano144 @HeadHunter483 @vadimalekseev