Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Run tests with race flag #437

Merged
merged 17 commits into from
Jul 31, 2023
Merged

CI: Run tests with race flag #437

merged 17 commits into from
Jul 31, 2023

Conversation

vadimalekseev
Copy link
Collaborator

Fixes #309

@vadimalekseev vadimalekseev changed the title Run tests with race flag CI: Run tests with race flag Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.07% ⚠️

Comparison is base (28feecb) 67.94% compared to head (3ffafea) 67.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   67.94%   67.88%   -0.07%     
==========================================
  Files         104      104              
  Lines       10559    10567       +8     
==========================================
- Hits         7174     7173       -1     
- Misses       2926     2934       +8     
- Partials      459      460       +1
Files Changed Coverage Δ
pipeline/pipeline.go 64.99% <0.00%> (-0.90%) ⬇️
plugin/input/journalctl/reader.go 66.66% <25.00%> (ø)
test/test.go 92.35% <60.00%> (-0.51%) ⬇️
plugin/input/journalctl/journalctl.go 73.43% <70.00%> (+2.74%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vano144
vano144 reviewed Jul 31, 2023
View reviewed changes
pipeline/pipeline.go
@@ -612,7 +612,7 @@ func (p *Pipeline) expandProcs() {
}

for x := 0; x < int(to-from); x++ {
proc := p.newProc(p.Procs[from].id + x)
proc := p.newProc(p.Procs[from-1].id + x)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add comment about it

@vadimalekseev vadimalekseev merged commit 634eeff into master Jul 31, 2023
@vadimalekseev vadimalekseev deleted the 309-race-flag branch July 31, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vano144 vano144 vano144 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Run test with -race flag
2 participants
@vadimalekseev @vano144