Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor metric.Ctl #328

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Refactor metric.Ctl #328

merged 3 commits into from
Apr 4, 2023

Conversation

vadimalekseev
Copy link
Collaborator

Fixes #327

@vadimalekseev vadimalekseev force-pushed the 327-refactor-metrics branch 2 times, most recently from 493fb6f to f111b27 Compare April 3, 2023 13:26
@vadimalekseev vadimalekseev force-pushed the 327-refactor-metrics branch 3 times, most recently from 5eb7b21 to 838dee5 Compare April 3, 2023 15:01
@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 62.39% and project coverage change: +0.19 🎉

Comparison is base (ccfda58) 63.35% compared to head (47ffe02) 63.55%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   63.35%   63.55%   +0.19%     
==========================================
  Files         105      105              
  Lines        9945    10098     +153     
==========================================
+ Hits         6301     6418     +117     
- Misses       3228     3253      +25     
- Partials      416      427      +11
Impacted Files Coverage Δ
pipeline/plugin.go 82.35% <ø> (ø)
plugin/action/add_file_name/add_file_name.go 100.00% <ø> (ø)
plugin/action/add_host/add_host.go 84.21% <ø> (ø)
plugin/action/convert_date/convert_date.go 72.09% <ø> (ø)
...ugin/action/convert_log_level/convert_log_level.go 100.00% <ø> (ø)
plugin/action/debug/debug.go 35.71% <ø> (ø)
plugin/action/discard/discard.go 100.00% <ø> (ø)
plugin/action/flatten/flatten.go 89.28% <ø> (ø)
plugin/action/join/join.go 89.70% <ø> (ø)
plugin/action/join_template/join_template.go 74.28% <ø> (ø)
... and 40 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

HeadHunter483
HeadHunter483 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@HeadHunter483 HeadHunter483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vadimalekseev vadimalekseev force-pushed the 327-refactor-metrics branch from 838dee5 to df85072 Compare April 4, 2023 08:28
@vadimalekseev vadimalekseev force-pushed the 327-refactor-metrics branch from df85072 to e3cd855 Compare April 4, 2023 09:39
@vadimalekseev vadimalekseev merged commit c87516c into master Apr 4, 2023
@vadimalekseev vadimalekseev deleted the 327-refactor-metrics branch April 4, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSmolonogov DSmolonogov DSmolonogov approved these changes

@HeadHunter483 HeadHunter483 HeadHunter483 approved these changes

@vano144 vano144 vano144 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Refactor metric.Ctl propagination
4 participants
@vadimalekseev @vano144 @HeadHunter483 @DSmolonogov