Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new way using metrics #169

Merged
merged 21 commits into from
Oct 12, 2022
Merged

new way using metrics #169

merged 21 commits into from
Oct 12, 2022

Conversation

DSmolonogov
Copy link
Collaborator

@DSmolonogov DSmolonogov commented Aug 18, 2022 •
edited
Loading

Description

new way using metrics

Fixes #168

@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch 3 times, most recently from c9d567f to d3df1f6 Compare August 18, 2022 10:11
@ansakharov ansakharov self-requested a review August 18, 2022 15:45
@ansakharov
Copy link
Contributor

Please add issue that you fixes.
For more info read: quide

ansakharov
ansakharov suggested changes Aug 18, 2022
View reviewed changes
metric/metricsController.go Outdated Show resolved Hide resolved
metric/metricsController.go Outdated Show resolved Hide resolved
metric/metricsController.go Outdated Show resolved Hide resolved
metric/metricsController.go Outdated Show resolved Hide resolved
metric/metricsController.go Outdated Show resolved Hide resolved
pipeline/pipeline.go Outdated Show resolved Hide resolved
@DSmolonogov DSmolonogov linked an issue Aug 18, 2022 that may be closed by this pull request
Feature: metrics refactoring #168
Closed
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch 3 times, most recently from d895862 to 85d4879 Compare August 19, 2022 10:37
ansakharov
ansakharov reviewed Aug 19, 2022
View reviewed changes
pipeline/antispamer.go Outdated Show resolved Hide resolved
ansakharov
ansakharov reviewed Aug 19, 2022
View reviewed changes
fd/file.d.go Outdated Show resolved Hide resolved
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from 85d4879 to bad89fe Compare August 19, 2022 13:13
@DSmolonogov DSmolonogov requested a review from ansakharov August 19, 2022 13:29
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from bad89fe to 3040412 Compare August 22, 2022 12:10
ansakharov
ansakharov reviewed Aug 22, 2022
View reviewed changes
pipeline/antispamer.go Outdated Show resolved Hide resolved
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch 6 times, most recently from f7b0ba2 to 98337e7 Compare August 24, 2022 15:45
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch 3 times, most recently from 94bcdc8 to eed78dd Compare August 25, 2022 09:32
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from 1affc6a to 21998d0 Compare September 8, 2022 14:13
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from 21998d0 to 37be5dc Compare September 19, 2022 08:45
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch 3 times, most recently from cec4147 to 376fb73 Compare September 19, 2022 11:18
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from 376fb73 to c84a25d Compare September 19, 2022 11:21
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Base: 55.90% // Head: 55.39% // Decreases project coverage by -0.51% ⚠️

Coverage data is based on head (6e0fc5e) compared to base (6716f87).
Patch coverage: 59.05% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   55.90%   55.39%   -0.52%     
==========================================
  Files          68       68              
  Lines        6876     6761     -115     
==========================================
- Hits         3844     3745      -99     
+ Misses       2737     2723      -14     
+ Partials      295      293       -2
Impacted Files Coverage Δ
pipeline/processor.go 0.00% <0.00%> (ø)
plugin/action/add_host/add_host.go 100.00% <ø> (ø)
plugin/action/convert_date/convert_date.go 69.76% <ø> (ø)
...ugin/action/convert_log_level/convert_log_level.go 100.00% <ø> (ø)
plugin/action/discard/discard.go 100.00% <ø> (ø)
plugin/action/flatten/flatten.go 89.28% <ø> (ø)
plugin/action/join/join.go 85.29% <ø> (ø)
plugin/action/join_template/join_template.go 74.28% <ø> (ø)
plugin/action/json_decode/json_decode.go 74.28% <ø> (ø)
plugin/action/json_encode/json_encode.go 85.00% <ø> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from 22b533c to 9bb7f53 Compare October 4, 2022 10:13
vitkovskii
vitkovskii requested changes Oct 6, 2022
View reviewed changes
pipeline/pipeline.go Outdated Show resolved Hide resolved
plugin/action/mask/mask.go Outdated Show resolved Hide resolved
plugin/emptyMetricRegister.go Outdated Show resolved Hide resolved
@DSmolonogov DSmolonogov requested a review from vitkovskii October 7, 2022 09:25
ansakharov
ansakharov suggested changes Oct 7, 2022
View reviewed changes
plugin/output/postgres/postgres_test.go Outdated Show resolved Hide resolved
plugin/output/stdout/stdout.go Show resolved Hide resolved
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from a480809 to ebbe665 Compare October 7, 2022 11:13
@DSmolonogov DSmolonogov requested a review from ansakharov October 7, 2022 16:02
HeadHunter483
HeadHunter483 reviewed Oct 7, 2022
View reviewed changes
metric/controller.go Outdated Show resolved Hide resolved
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from ebbe665 to 55edfc8 Compare October 7, 2022 16:46
ansakharov
ansakharov approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@ansakharov ansakharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from 55edfc8 to cc62f8f Compare October 12, 2022 13:58
@DSmolonogov DSmolonogov force-pushed the 168-file.d-refactoring-metrics branch from cc62f8f to 6e0fc5e Compare October 12, 2022 14:03
@vano144 vano144 merged commit 79f3247 into master Oct 12, 2022
@vano144 vano144 deleted the 168-file.d-refactoring-metrics branch October 12, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansakharov ansakharov ansakharov approved these changes

@vadimalekseev vadimalekseev vadimalekseev approved these changes

@vitkovskii vitkovskii Awaiting requested review from vitkovskii

@HeadHunter483 HeadHunter483 Awaiting requested review from HeadHunter483

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: metrics refactoring
6 participants
@DSmolonogov @ansakharov @vitkovskii @HeadHunter483 @vadimalekseev @vano144