forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor most of the components to outside of their Session folder #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also sort admins first in UpdateGroupMembers dialog
Bilb
added a commit
that referenced
this pull request
Dec 17, 2021
* Added message requests disabled for now * no longer showing empty space for conversations moved from list. * Added syncing accepting of contact between running instances. * Adding blocking of individual requests and syncing of block to devices. Added approval by replying to a message. * fixed typos for translations and method name. * Blocking, accepting on click and accepting on msg send working across clients. * adding setting of active_at to hide unapproved messages. * adding feature flag for config message receiving * fix archlinux pw unused issue on archlinux, the appimage links to the system sqlite by default which does not support sqlcipher * hide activeAt = 0 convo from search results Fixes #2033 * opengroup messages from blocked user are dropped Fixes #2019 * opengroup messages from blocked user are dropped Fixes #2019 * dismiss a call when answered from another of our devices * add data-testid for leftpane sections and edit profile dialog * update turn servers * cleanup sessionprotobuf * move the state of calling to its own slice * no video track by default and will be turn ON if asked to * message request refactoring. * create offer and answer ourselves and do not use the negotiation needed event. this event is causing us to loop in negotiation needed when each side try to create one, gets the answer and so on... * auto select the first audio input on connection success webrtc * add a way to choose the audioouput/mute a webrtc call * mute audio from bg when video is in fullscreen this is to avoid having two times the remote sound playing one in the bg and one in the fullscreen * Adding improvements to message request handling. * Only updating approval when it is a true value as we consider a block a decline. * Linting and formatting. * More formatting and linting * fixing merge conflicts * linting and formatting changes * darken a bit the green of sent message box in light theme * disable deduplication based serverId+sender only use the serverTimestamp+sender for searching because serverId+sender might have false positive * Fixing up block all logic. * speed up fetching closed group's members avatar * Applying PR changes. * cleanup props passing of avatar and name with a custom hook * fix a bug releasing the decrypted attachment blobs too early * Adding trigger logic for conversation filtering of requests. * Fixing rimraf transpile bug. Adding PR fixes - icon buttons. * Minor call tweaks (#2051) * show missed-call,started-call and answered call notification in chat * fix types for createLastMessageUpdate * show incoming dialog if we have a pending call when enable call receptio * simplify a bit the avatar component * move disableDrag to a custom hook * speed up hash colors of avatarPlaceHolders * fixup text selection and double click reply on message * keep avatar decoded items longer before releasing memory * add incoming/outgoing/missed call notification also, merge that notification with the timer and group notification component * hangup call if no answer after 30sec * refactor SessionInput using hook + add testid field for recovery * disable message request feature flag for now * fix merge issue * force loading screen to be black instead of white for our dark theme user's eyes safety * Fetch translations (#2056) * show missed-call,started-call and answered call notification in chat * fix types for createLastMessageUpdate * show incoming dialog if we have a pending call when enable call receptio * simplify a bit the avatar component * move disableDrag to a custom hook * speed up hash colors of avatarPlaceHolders * fixup text selection and double click reply on message * keep avatar decoded items longer before releasing memory * add incoming/outgoing/missed call notification also, merge that notification with the timer and group notification component * hangup call if no answer after 30sec * refactor SessionInput using hook + add testid field for recovery * disable message request feature flag for now * fix merge issue * force loading screen to be black instead of white for our dark theme user's eyes safety * add type for i18n to run update after crowdin fetch with tools/updateI18nKeysType.py * update to latest translations * Open group regex fixes (#2058) * Open group URL regex fixes - Capital letters in room tokens were not being accepted (it eventually gets lower-cased internally, which works fine, but that happens *after* the URL is tested for acceptability). - `-` in room was not being allowed (it is and always has been on SOGS, session-android, and session-ios). - single-letter room ids are valid, but only 2+ letter ids were being accepted. - complete URL regex wasn't anchored so something like `garbagehttps://example.com/room?public_key=<64hex>moregarbage` was being accepted in the GUI input (it fails later when other code tries to parse it as a URL). - removed `m` modifier from open group regex: without anchors it wasn't doing anything anyway, but *with* anchors it would still allow leading/trailing garbage if delineated by newlines. - public key regex was accepting g-z letters, and not accepting A-F. - various regex cleanups: - use non-capture groups (?:...) rather than capturing groups (...) - avoid repetition in host segment matching - tightened up host pattern matching a bit: - DNS host segments have a max length of 63 - Limit port max length to 5, and disallow starting with 0 * Show an error when the open group URL is invalid It's quite disconcerting when you have a bad open group URL and try to add it and the join button just "doesn't work" without any feedback at all. Fix it to show an error message. (There is already an i18n entry for this because this same message is thrown if the URL can't be parsed later on). * Add call duration (#2059) * add call duration once connected * close incoming call dialog if endCall from same sender * disable message request toggle if featureFlag is OFF * Cleanup message request (#2063) * close incoming call dialog if endCall from seame sender * disable message request toggle if featureFlag is OFF * cleanup UI of message requests * mark all existing conversations as approved in a migration * fix regex with conversationID for opengroups * Various UI fixes (#2070) * cleanup unused convo json fields in db * display a toast if the user is not approved yet on call OFFER received * enable CBR for calls * do not update active_at on configMessage if !!active_at * remove mkdirp dependency * disable call button if focused convo is blocked * quote: do not include the full body in quote, but just the first 100 * click on the edit profile qr code padding * Allow longer input for opengroup join overlay Fixes #2068 * Fix overlay feature for start new session button * make ringing depend on redux CALL status * turn ON read-receipt by default * keep read-receipts disabled by default (#2071) * refactor most of the components to outside of their Session folder (#2072) * refactor most of the components to outside of their Session folder * finish moving overlay and memberListItem to react hook * fix bug with kicked member len >2 not being displayed also sort admins first in UpdateGroupMembers dialog * fix admin leaving text of groupNotification * add a useFocusMount hook to focus input fields on mount * make click avatar convo item open only user dialog * cleanup config default.json * make sure to use convoController to build sync message * disable showing pubkey on opengroups * add a pause on audio playback Fixes #2079 * Minor styling fix for large amount of message requests (#2080) * Minor styling fix for large amount of message requests * Vertical center fix for message request banner. * removing top margin from banner again. * reactify group updates text bubble from redux store (#2083) * add crown icon for closed group admins (#2084) * disable call for now + fix left pane actions overflow (#2085) * Fix attachment dl freeze (#2086) * fix attachment download freezing app for some opengroups * make registration page work with smaller height * Unban UI (#2091) * adding basic functionaliy for unbanning a user * merge ban and unban user dialog in to one dialog Co-authored-by: warrickct <warrickct@gmail.com> * use React Provider for convoListItem (#2088) this is to avoid passing down the prop to all the components * fix closed group updates undefined on no names (#2092) Co-authored-by: Warrick Corfe-Tan <warrickct@gmail.com> Co-authored-by: Jason Rhinelander <jason@imaginary.ca> Co-authored-by: Warrick <wcor690@aucklanduni.ac.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.