Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check access rights for OUTPUT_PATH #486

Merged
merged 1 commit into from
Sep 3, 2015

Conversation

alexandrasandulescu
Copy link
Contributor

I hardcoded /.owtf. Where should this default path be added? default.cfg is not a good idea because users can modify it and we want "/.owtf" to be the failure solution for bad config.

@alexandrasandulescu
Copy link
Contributor Author

Plus, I tested it on Arch Linux where the source is copied by pacman to /usr/share/owtf

@flabbergastedbd
Copy link
Contributor

Hardcoding ~/.owtf should ideally be done in framework/config/framework_config.cfg

@alexandrasandulescu
Copy link
Contributor Author

@tunnelshade , please check the fix

@alexandrasandulescu alexandrasandulescu force-pushed the develop branch 2 times, most recently from 11a3115 to 1475f07 Compare August 1, 2015 12:58
@alexandrasandulescu
Copy link
Contributor Author

@DePierre thanks. I'll keep that in mind . fixed

@alexandrasandulescu alexandrasandulescu force-pushed the develop branch 2 times, most recently from 1dad784 to e13af15 Compare August 1, 2015 19:24
@viyatb
Copy link
Member

viyatb commented Aug 1, 2015

@tao: Sphinx syntax has not been written for the majority part of OWTF - isn't just the docstrings sufficient for this case?
Rephrase opinion below!

@DePierre
Copy link
Contributor

DePierre commented Aug 1, 2015

@delta24 Your comment makes me so sad...

I am trying my best since almost 2 years to push pep8 code with sphinx-like docstrings step by step for any new code I am adding to the codebase. If anyone would do the same day after day, the codebase would be easier to read. Instead, it is just unbearable, nobody understands anything, no doc, no coding rules, nothing.

Please reconsider writing PEP8 code with Sphinx docstrings for, at least, any new added code.

@viyatb
Copy link
Member

viyatb commented Aug 1, 2015

Let me rephrase this: Don't get me wrong. Sphinx-like docstring comments are invaluable for any code. But as a practice, I think either the whole module/ or the whole .py file should have them, not only the newly added code. If @alexandrasandulescu is ready to add the docstring comments for the whole module, well and good!
Cheers!

@DePierre
Copy link
Contributor

DePierre commented Aug 1, 2015

No one will ever write documentation for OWTF at once but going step by step makes everything possible.
Sure it would be nice to have sphinx docs for all functions but are you ready to do that? I don't think so.
This is childish to use the "yes but no one else does so why should I do that?"
Also, this is a requirement for OSCS
https://www.owasp.org/index.php/Summer_Code_Sprint2015#OWASP_OWTF_-_HTTP_Request_Translator_Improvements
Check the Expected Results

@flabbergastedbd
Copy link
Contributor

Okay guys, @delta24 It is good to have docstrings for the whole module but as @DePierre says it cannot be done overnight. Once we start writing it for the new code that we write we will get accustomed to it and subsequently will be useful.

@alexandrasandulescu Use a PEP8 checker with your IDE/Editor to follow PEP-8

@alexandrasandulescu
Copy link
Contributor Author

@tunnelshade , fixed

flabbergastedbd pushed a commit that referenced this pull request Sep 3, 2015
Check access rights for OUTPUT_PATH
@flabbergastedbd flabbergastedbd merged commit 9d2a6c0 into owtf:develop Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants