-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check access rights for OUTPUT_PATH #486
Conversation
Plus, I tested it on Arch Linux where the source is copied by pacman to /usr/share/owtf |
2346b14
to
f8947bb
Compare
Hardcoding ~/.owtf should ideally be done in |
f8947bb
to
690aa9a
Compare
@tunnelshade , please check the fix |
11a3115
to
1475f07
Compare
@alexandrasandulescu Could you please fix the coding style in your pull requests? We are
PEP8:
PEP257: Sphinx: |
1475f07
to
c8df0a4
Compare
@DePierre thanks. I'll keep that in mind . fixed |
1dad784
to
e13af15
Compare
@tao: |
@delta24 Your comment makes me so sad... I am trying my best since almost 2 years to push pep8 code with sphinx-like docstrings step by step for any new code I am adding to the codebase. If anyone would do the same day after day, the codebase would be easier to read. Instead, it is just unbearable, nobody understands anything, no doc, no coding rules, nothing. Please reconsider writing PEP8 code with Sphinx docstrings for, at least, any new added code. |
Let me rephrase this: Don't get me wrong. Sphinx-like docstring comments are invaluable for any code. But as a practice, I think either the whole module/ or the whole |
No one will ever write documentation for OWTF at once but going step by step makes everything possible. |
Okay guys, @delta24 It is good to have docstrings for the whole module but as @DePierre says it cannot be done overnight. Once we start writing it for the new code that we write we will get accustomed to it and subsequently will be useful. @alexandrasandulescu Use a PEP8 checker with your IDE/Editor to follow PEP-8 |
e13af15
to
81a0357
Compare
@tunnelshade , fixed |
Check access rights for OUTPUT_PATH
I hardcoded
/.owtf. Where should this default path be added? default.cfg is not a good idea because users can modify it and we want "/.owtf" to be the failure solution for bad config.