Templated render stages #1177
Merged
Templated render stages #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HifiExperiments
added
needs CR
HifiExperiments
force-pushed
the
stages
branch
2 times, most recently
from
e083854 to
1b5fdb4
Compare
HifiExperiments
force-pushed
the
stages
branch
from
1b5fdb4 to
ac3730c
Compare
ksuprynowicz
approved these changes
Nov 1, 2024
ksuprynowicz
added
CR approved
|
I tested it in desktop mode and everything works perfectly, we just need to test in VR now. |
|
I had a crash with this message, but it seems tricky to reproduce and it's possible that it's unrelated: |
|
Other than this it works well in desktop mode, everything renders correctly. |
|
yeah definitely unrelated, looks like maybe ktx corruption. this was just purely refactoring how we pass around some objects, basically if lighting and effects are working then it’s all good! thank you for testing |
|
I will test it in VR and then I think it will be safe to merge |
|
Works perfectly in VR too :) |
ksuprynowicz
added
QA approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a lot of XXXXStage classes, which are responsible for passing data from various places to the various tasks that actually render different effects (like the skybox, bloom, AO, etc.). as we've added more, they've gotten a bit out of control, and it's cumbersome to add more. the classes were all very similar, so I've created some templated classes in Stage.h to deduplicate a lot of code.