Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3716 #3733

Merged
merged 3 commits into from
Jul 22, 2023
Merged

fix #3716 #3733

merged 3 commits into from
Jul 22, 2023

Conversation

dylan-conway
Copy link
Member

fixes #3716

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

@dylan-conway 2 files with test failures on linux-x64:

  • test/bundler/esbuild/ts.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#36c755ca7b3186a4ca5b8d537f5e756af692b50f

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

@dylan-conway 2 files with test failures on linux-x64-baseline:

  • test/bundler/esbuild/ts.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#36c755ca7b3186a4ca5b8d537f5e756af692b50f

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

@dylan-conway 8 files with test failures on bun-darwin-aarch64:

  • test/bundler/esbuild/extra.test.ts
  • test/bundler/esbuild/ts.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/fetch/fetch_headers.test.js

View test output

#36c755ca7b3186a4ca5b8d537f5e756af692b50f

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

@dylan-conway 6 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/esbuild/ts.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/sleepSync.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#36c755ca7b3186a4ca5b8d537f5e756af692b50f

Parser.parse(&source, this.allocator, this.map, true, true);
for (std.os.environ) |_env| {
var env = bun.span(_env);
if (strings.indexOfChar(env, '=')) |i| {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder what happens if an env key has an = in it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylan-conway dylan-conway merged commit 2323f5d into main Jul 22, 2023
@dylan-conway dylan-conway deleted the dylan/fix-3716 branch July 22, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bun.env truncates .env string values containing # when run as an npm script
2 participants