-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3716 #3733
fix #3716 #3733
Conversation
❌ @dylan-conway 2 files with test failures on linux-x64:
|
❌ @dylan-conway 2 files with test failures on linux-x64-baseline:
|
❌ @dylan-conway 8 files with test failures on bun-darwin-aarch64:
|
❌ @dylan-conway 6 files with test failures on bun-darwin-x64-baseline:
|
Parser.parse(&source, this.allocator, this.map, true, true); | ||
for (std.os.environ) |_env| { | ||
var env = bun.span(_env); | ||
if (strings.indexOfChar(env, '=')) |i| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder what happens if an env key has an =
in it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to Stack Overflow, this is correct
fixes #3716