Fix streams breaking on reverted EventEmitter / Make Discord.js work #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave [warn] src/bun.js/events.exports.js
[warn] Code style issues found in the above file. Forgot to run Prettier?
error: "prettier" exited with code 1 (SIGHUP)
Checking formatting...To one-off fix this manually, run: bun fmtYou might need to run |
src/bundler/entry_points.zig
Outdated
| @@ -192,7 +192,7 @@ pub const ServerEntryPoint = struct { | |||
| \\var cjs = start?.default; | |||
| \\if (cjs && typeof cjs === 'function' && cjsSymbol in cjs) {{ | |||
| \\ // if you module.exports = (class {{}}), don't call it | |||
| \\ entryNamespace = ("prototype" in cjs) ? cjs : cjs(); | |||
| \\ entryNamespace = import.meta.primordials.isCallable(cjs) ? cjs() : cjs; | |||
There was a problem hiding this comment.
this shouldn't be in here
src/bun.js/events.exports.js
Outdated
|
|
||
| EventEmitter.prototype[kCapture] = false; | ||
|
|
||
| function once(emitter, type, { signal } = {}) { |
There was a problem hiding this comment.
we can't set a default argument in the function this way
people will pass null or something truthy and then get a very strange error
src/bun.js/events.exports.js
Outdated
| } | ||
| EventEmitter.once = once; | ||
|
|
||
| function on(emitter, type, { signal, close, highWatermark = Number.MAX_SAFE_INTEGER, lowWatermark = 1 } = {}) { |
src/bun.js/events.exports.js
Outdated
| } | ||
| } | ||
|
|
||
| EventEmitter.prototype._events = undefined; |
There was a problem hiding this comment.
instead of
EventEmitter.prototypePeople might mess with it at runtime
Instead, lets assign it to a local variable and use that one
const EventEmitterPrototype = EventEmitter.prototype;
|
❌ @paperdave 27 files with test failures on linux-x64-baseline:
|
|
❌ @paperdave 27 files with test failures on linux-x64:
|
|
❌ @paperdave 30 files with test failures on bun-darwin-x64-baseline:
|
paperclover
changed the title
This reverts commit a4d0a19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2707, Closes #2077
fixes some of the things that were reverted before
in addition to this, it makes discord.js work
note for the first one, it does cause slower runtime with
and we could totally optimize this simple use case too but i did not do that.
there were two fixes to this, and i went with (2)
1 = current
2 = lazy init + old event emitter from 0.6 and prior
3 = lazy init + js event emitter + pure js streams