Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed punctuation on homepage. #280

Merged
merged 5 commits into from
Jul 14, 2022
Merged

fix: Fixed punctuation on homepage. #280

merged 5 commits into from
Jul 14, 2022

Conversation

mustafahasankhan
Copy link
Contributor

Congratulations on the launch, much excited for this project.
Fixed a punctuation on home page.

@nodeicode
Copy link

nodeicode commented Jul 6, 2022 •
edited
Loading

changes are hard to read, tldr: this PR is changing
The goal of Bun is to run most of the worlds JavaScript outside of browsers
to
The goal of Bun is to run most of the world's JavaScript outside of browsers

@mustafahasankhan
Copy link
Contributor Author

changes are hard to read, tldr: this PR is changing The goal of Bun is to run most of the worlds JavaScript outside of browsers to The goal of Bun is to run most of the world's JavaScript outside of browsers

Just added a missing apostrophe. ' denotes the apostrophe.

@Tropix126
Copy link
Contributor

This is changing the compiled version of the webpage and not the actual source of it. You should probably be making your changes to src/page.tsx rather than anything in public.

michellbrito
michellbrito suggested changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@michellbrito michellbrito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit the index.html instead edit the src/page.tsx like @Tropix126 mentioned

@mustafahasankhan
Copy link
Contributor Author

[Update] Added changes to source too.

michellbrito
michellbrito previously requested changes Jul 11, 2022
View reviewed changes
packages/bun-landing/public/index.html Outdated Show resolved Hide resolved
@FinnRG FinnRG mentioned this pull request Jul 12, 2022
Merged
@FinnRG
Copy link
Collaborator

FinnRG commented Jul 13, 2022

@mustafahasankhan Could you please undo the changes to the build output?

@mustafahasankhan
Copy link
Contributor Author

@mustafahasankhan Could you please undo the changes to the build output?

Done!

@FinnRG FinnRG dismissed michellbrito’s stale review July 14, 2022 18:19

Requested changes were adressed

@FinnRG FinnRG merged commit 0d65a1f into oven-sh:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FinnRG FinnRG FinnRG approved these changes

@nodeicode nodeicode nodeicode approved these changes

@michellbrito michellbrito michellbrito left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mustafahasankhan @nodeicode @Tropix126 @FinnRG @michellbrito