Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server) fix flushing #13207

Merged
merged 4 commits into from
Aug 10, 2024
Merged

fix(server) fix flushing #13207

merged 4 commits into from
Aug 10, 2024

Conversation

cirospaciari
Copy link
Member

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Added a test

@robobun
Copy link

robobun commented Aug 9, 2024 •
edited
Loading

❌ @cirospaciari, your commit 127ed6d has 13 failures in #1635:

  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🪟 x64
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 x64-baseline
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - timeout on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - timeout on 🪟 x64
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/jsc/bun-jsc.test.ts - timeout on 🪟 x64
  • test/js/bun/jsc/bun-jsc.test.ts - timeout on 🪟 x64-baseline
  • test/js/web/timers/setInterval.test.js - 1 failing on 🪟 x64-baseline
  • test/js/web/timers/setInterval.test.js - 1 failing on 🪟 x64
  • test/cli/hot/hot.test.ts - 2 failing on 🪟 x64
  • test/cli/hot/hot.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/node/http/node-http.test.ts - 1 failing on 🪟 x64
  • test/js/node/fs/fs.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 2 failing on 🪟 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64
  • test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🍎 13 x64
  • test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64
    		•

    @Jarred-Sumner Jarred-Sumner merged commit 24dbef7 into main Aug 10, 2024
    45 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the ciro/fix-uws-flush branch August 10, 2024 01:20
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @cirospaciari @robobun @Jarred-Sumner