Remove some dynamic memory allocations in uWebSockets #12897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner, your commit has failing tests :( 💻 1 failing tests Darwin x64 baseline
🪟💻 3 failing tests Windows x64 baseline
🪟💻 3 failing tests Windows x64
|
This comment was marked as outdated.
This comment was marked as outdated.
cirospaciari
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
MovableFunctionin uWebSockets is a mostly unnecessary memory allocation. We can instead use C function pointers, since that's what we're using anyway.Also removed the c-api folder, because it's confusing to have two different versions of the same thing
How did you verify your code works?
Ran it