Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that ccache points to a regular file instead of a non-empty string #12382

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Check that ccache points to a regular file instead of a non-empty string #12382

merged 1 commit into from
Jul 6, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Check that ccache points to a regular file instead of a non-empty string

How did you verify your code works?

This doesn't print hi:

if [ -f /opt/homebrew/bin/node123 ]; then
  echo 'hi'
fi

This does print hi:

if [ -f /opt/homebrew/bin/node ]; then
  echo 'hi'
fi

@Jarred-Sumner Jarred-Sumner requested a review from paperclover July 6, 2024 01:15
anonrig
anonrig reviewed Jul 6, 2024
View reviewed changes
Copy link

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Jarred-Sumner Jarred-Sumner merged commit da1b3d2 into main Jul 6, 2024
30 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/ccache branch July 6, 2024 01:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 6, 2024

❌ @Jarred-Sumner, your commit has failing tests :(

🪟💻 4 failing tests Windows x64 baseline

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/js/node/child_process/child_process.test.ts 1 failing
  • test/js/node/tls/node-tls-connect.test.ts 1 failing

🪟💻 4 failing tests Windows x64

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/js/node/child_process/child_process.test.ts 1 failing
  • test/js/node/tls/node-tls-connect.test.ts 1 failing

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@paperclover paperclover paperclover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jarred-Sumner @anonrig @paperclover