Fix crash on aborted timer #12348
Merged
Fix crash on aborted timer #12348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadzim
force-pushed
the
fix-crash-on-aborted-timer
branch
from
a979590 to
77c96e7
Compare
vadzim
force-pushed
the
fix-crash-on-aborted-timer
branch
from
77c96e7 to
702eab9
Compare
|
❌ @vadzim, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
🪟💻 4 failing tests Windows x64 baseline
🪟💻 3 failing tests Windows x64
|
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #12347
return the promise returned by .finally() instead of bare returnValue to allow the user code to catch emitted abort error
How did you verify your code works?
I wrote automated tests
bun-debug test test-file-name.test)