New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect package.json indentation in `bun install` #12328

Merged

Jarred-Sumner merged 5 commits into main from dylan/packagejson-indentation

Jul 4, 2024

Member

dylan-conway commented Jul 3, 2024 •

edited

Loading

What does this PR do?

fixes #4563
fixes #3107

How did you verify your code works?

added a test

dylan-conway and others added 5 commits

July 3, 2024 15:24


          detect indentation

5b68150


          make workspaces work

4cdf889


          handle starting with newline

c8419e1


          remove only

89c10d1


          Merge branch 'main' into dylan/packagejson-indentation

3f00357

Contributor

github-actions bot commented Jul 4, 2024

❌ @dylan-conway, your commit has failing tests :(

💻 2 failing tests Darwin x64

test/integration/expo-app/expo.test.ts SIGKILL
test/js/node/module/node-module-module.test.js 1 failing

🪟💻 4 failing tests Windows x64 baseline

test/cli/install/registry/bun-install-registry.test.ts 3 failing
test/cli/install/registry/bun-install-windowsshim.test.ts code 1
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/js/node/child_process/child_process.test.ts 1 failing

🪟💻 3 failing tests Windows x64

test/cli/install/registry/bun-install-registry.test.ts 1 failing
test/cli/install/registry/bun-install-windowsshim.test.ts code 1
test/js/node/child_process/child_process.test.ts 1 failing

dylan-conway assigned Jarred-Sumner

Jarred-Sumner merged commit 4fefb85 into main

49 of 52 checks passed

Jarred-Sumner deleted the dylan/packagejson-indentation branch

July 4, 2024 06:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet