Implement buffer.resolveObjectURL
#12324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
requested review from
a team,
erik-dunteman and
paperclover
and removed request for
a team and
erik-dunteman
paperclover
approved these changes
Jul 3, 2024
| // Not thrown. | ||
| // https://github.com/nodejs/node/blob/2eff28fb7a93d3f672f80b582f664a7c701569fb/lib/internal/blob.js#L441 | ||
| if (arguments.len < 1) { | ||
| return JSC.JSValue.undefined; |
There was a problem hiding this comment.
reminder that these can be written as just return .undefined;
| @@ -1,3 +1,7 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
i think these files were used in a weird way where this root.h isnt needed but i think this is reasonable to have nonetheless since it compiles
|
❌ @Jarred-Sumner, your commit has failing tests :( 🪟💻 4 failing tests Windows x64 baseline
🪟💻 4 failing tests Windows x64
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12322
Links:
How did you verify your code works?
Copied some tests from Node