-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install: fix issues with patching hoisted dependencies in workspaces #12141
Conversation
❌ @dylan-conway, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
🐧💪 1 failing tests Linux AARCH64
🪟💻 4 failing tests Windows x64 baseline
🪟💻 3 failing tests Windows x64
|
windows test failures |
Was curious to know if this might be making it into a release soon? The team over here at Motion is pretty anxious to try and swap yarn out for bun at the install layer and we think this is the last blocker. |
Exactly the same situation over here. 😅 |
Same here |
@Scalahansolo @flokol120 @Thiagolino8 We plan to have this included in the next release (1.1.18). There isn't a date for the release yet, but I would expect first half of next week |
What does this PR do?
Fixes #12103
Specifically the issue was
bun patch
not properly handling hoisted dependencies in workspaces