Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update counter cache when a user is deleted (or) suspended #8222

Merged
merged 1 commit into from
Jan 11, 2025
Merged

fix: Update counter cache when a user is deleted (or) suspended #8222

merged 1 commit into from
Jan 11, 2025

Conversation

hmacr
Copy link
Collaborator

@hmacr hmacr commented Jan 11, 2025 •
edited
Loading

In userSuspender and UserDeletedProcessor flows, GroupUser deletion triggers an afterBulkDestroy hook - however we need the afterDestroy hook on each instance to update the group member counter cache.

It's not ideal to listen to afterBulkDestroy hook since it won't have the deleted instances data.

@hmacr hmacr requested a review from tommoor January 11, 2025 02:33
@tommoor tommoor merged commit e910ecf into main Jan 11, 2025
11 checks passed
@hmacr hmacr deleted the hmacr/update-counter-cache branch January 11, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmacr @tommoor