Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve JSON Document Sorting Order During Import #8183

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Preserve JSON Document Sorting Order During Import #8183

merged 1 commit into from
Jan 2, 2025

Conversation

PrasadBandaru473
Copy link
Contributor

This pull request addresses issue #7532, where the sorting order of documents is lost during the import process.

Changes Made

  • Updated the mapDocuments function in ImportJSONTask to use the unshift method instead of push.
  • Added a comment explaining the reason for the reversal, noting that addDocumentToStructure uses index 0 for insertion.

References

@auto-assign auto-assign bot requested a review from tommoor January 2, 2025 14:01
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tommoor tommoor merged commit 9cab404 into outline:main Jan 2, 2025
9 checks passed
@PrasadBandaru473 PrasadBandaru473 deleted the 7532-sorting-info-is-lost branch January 3, 2025 07:06
@PrasadBandaru473 PrasadBandaru473 restored the 7532-sorting-info-is-lost branch January 3, 2025 07:06
@PrasadBandaru473 PrasadBandaru473 deleted the 7532-sorting-info-is-lost branch January 3, 2025 07:09
@PrasadBandaru473 PrasadBandaru473 restored the 7532-sorting-info-is-lost branch January 3, 2025 07:14
@PrasadBandaru473 PrasadBandaru473 deleted the 7532-sorting-info-is-lost branch January 3, 2025 07:15
@tommoor tommoor mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrasadBandaru473 @CLAassistant @tommoor