Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Group to model event writing #8179

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Move Group to model event writing #8179

merged 2 commits into from
Jan 2, 2025

Conversation

tommoor
Copy link
Member

@tommoor tommoor commented Jan 1, 2025

Towards #7920

@tommoor tommoor marked this pull request as ready for review January 1, 2025 21:14
@tommoor tommoor requested a review from hmacr January 1, 2025 21:14
@hmacr
Copy link
Collaborator

hmacr commented Jan 2, 2025

Just noticed the GroupEvent type can be cleaned up to remove the data field.

outline/server/types.ts

Lines 357 to 359 in b8c07eb

data: {
name: string;
};

@tommoor tommoor enabled auto-merge (squash) January 2, 2025 12:44
@tommoor tommoor merged commit 1c179a3 into main Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmacr hmacr hmacr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommoor @hmacr