Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow resizing of embed height #8154

Merged
merged 7 commits into from
Jan 2, 2025

Conversation

tommoor
Copy link
Member

@tommoor tommoor commented Dec 27, 2024

Towards #7652

@tommoor
Copy link
Member Author

tommoor commented Dec 29, 2024

I'm swaying if to do an entire rebuild of resizing or just get this improvement merged and come back to it

@tommoor tommoor marked this pull request as ready for review December 29, 2024 18:32
@Ali-ovo
Copy link
Contributor

Ali-ovo commented Dec 30, 2024

I have an idea, we get the aspect ratio, by jumping to the width of the automatic modification of the height can be equal to the proportion resize

@tommoor
Copy link
Member Author

tommoor commented Dec 30, 2024

There are no "natural" proportions for many of the embeds, so in that sense they're not like images.

@Ali-ovo
Copy link
Contributor

Ali-ovo commented Dec 30, 2024

There are no "natural" proportions for many of the embeds, so in that sense they're not like images.

I have used notion before, and its embed has a similar resize feature, and I think the experience is OK
(You can try embedding a youtube video in it to experience this feature)

@tommoor
Copy link
Member Author

tommoor commented Dec 30, 2024

Videos are kind of the one exception where they do have a natural size and act like images

@tommoor tommoor merged commit d645915 into main Jan 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants